The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method com.philemonworks.selfdiagnose.Instance.invoke(String, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 69 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.philemonworks.selfdiagnose.SelfDiagnoseListener.contextInitialized(ServletContextEvent) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 24 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on CheckDatabaseTableExists.PARAMETER_QUERY_SORTED_VALUES in com.philemonworks.selfdiagnose.check.CheckDatabaseTableExists.setUp(ExecutionContext) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 78 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Can't close dis since it is always null in com.philemonworks.selfdiagnose.check.CheckFileContainsString.run(ExecutionContext, DiagnosticTaskResult) | CORRECTNESS | NP_CLOSING_NULL | 100 | High |
| com.philemonworks.selfdiagnose.check.CheckFileContainsString.run(ExecutionContext, DiagnosticTaskResult) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 97 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from com.philemonworks.selfdiagnose.DiagnosticTaskResult to com.philemonworks.selfdiagnose.CompositeDiagnosticTaskResult in com.philemonworks.selfdiagnose.check.CheckPropertyValuesAreJavaTypes.run(ExecutionContext, DiagnosticTaskResult) | STYLE | BC_UNCONFIRMED_CAST | 89 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of com.philemonworks.selfdiagnose.PatternMatchingTask.pattern which is known to be null in com.philemonworks.selfdiagnose.check.CheckResourceProperty.run(ExecutionContext, DiagnosticTaskResult) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 88 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.philemonworks.selfdiagnose.check.vendor.CheckSpringBeanProperty defines non-transient non-serializable instance field applicationContext | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class com.philemonworks.selfdiagnose.check.vendor.CheckSpringDatasourceConnectable defines non-transient non-serializable instance field applicationContext | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.philemonworks.selfdiagnose.output.HTMLReporter.beginHTML() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 131 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from com.philemonworks.selfdiagnose.DiagnosticTaskResult to com.philemonworks.selfdiagnose.CompositeDiagnosticTaskResult in com.philemonworks.selfdiagnose.report.ReportMap.run(ExecutionContext, DiagnosticTaskResult) | STYLE | BC_UNCONFIRMED_CAST | 32 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| com.philemonworks.selfdiagnose.report.ReportMavenPOMProperties.run(ExecutionContext, DiagnosticTaskResult) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 63 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from com.philemonworks.selfdiagnose.DiagnosticTaskResult to com.philemonworks.selfdiagnose.CompositeDiagnosticTaskResult in com.philemonworks.selfdiagnose.report.ReportProperties.run(ExecutionContext, DiagnosticTaskResult) | STYLE | BC_UNCONFIRMED_CAST | 29 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from com.philemonworks.selfdiagnose.DiagnosticTaskResult to com.philemonworks.selfdiagnose.CompositeDiagnosticTaskResult in com.philemonworks.selfdiagnose.report.vendor.ReportJamonMonitors.run(ExecutionContext, DiagnosticTaskResult) | STYLE | BC_UNCONFIRMED_CAST | 39 | Medium |